Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR is not working out of box (does a full page refresh) #3215

Closed
lukemcgregor opened this issue Sep 28, 2017 · 2 comments
Closed

HMR is not working out of box (does a full page refresh) #3215

lukemcgregor opened this issue Sep 28, 2017 · 2 comments

Comments

@lukemcgregor
Copy link

lukemcgregor commented Sep 28, 2017

Is this a bug report?

Yes

Can you also reproduce the problem with npm 4.x?

Yes

Which terms did you search for in User Guide?

hmr, hot

Environment

  1. node -v: 8.3.0
  2. npm -v: 4.6.1
  3. yarn --version (if you use Yarn): 0.27.5
  4. npm ls react-scripts (if you haven’t ejected): 1.0.14

Then, specify:

  1. Operating system: macOS Sierra
  2. Browser and version (if relevant): Chrome 61.0.3163.100

Steps to Reproduce

cd whatever
npm run start
modify the Welcome to react text in an editor

(Write your steps here:)

  1. create-react-app whatever
  2. cd whatever
  3. npm run start
  4. Preserve log in the net tab on the site (Chrome)
  5. modify the Welcome to react text in an editor (in App.js) and save

Expected Behavior

The page should update without a full reload (eg it should HotReload).

Actual Behavior

If you look in the net tab its refreshing the page. You can also see it flicker as it reloads.

Something in the HMR stack isn't working correctly out of the box.

screen shot 2017-09-29 at 11 29 00 am

screen shot 2017-09-29 at 11 29 17 am

Reproducible Demo

https://github.com/lukemcgregor/create-react-hmr-not-working

see instructions above

@lukemcgregor
Copy link
Author

Oh i just read this isnt supported, seems like a pretty important feature though

@Timer
Copy link
Contributor

Timer commented Sep 29, 2017

See #2304

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants