Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig file #3637

Closed
ryan-ds17 opened this issue Dec 22, 2017 · 4 comments
Closed

Add .editorconfig file #3637

ryan-ds17 opened this issue Dec 22, 2017 · 4 comments

Comments

@ryan-ds17
Copy link

Is this a bug report?

No

Is it possible to add an .editorconfig file while scaffolding the project?

@viankakrisna
Copy link
Contributor

viankakrisna commented Dec 23, 2017

you can fork CRA and publish it if you want to customize the experience. in your case the code would be in packages/react-scripts/scripts/init.js

@heyimalex
Copy link
Contributor

Just add it yourself? It takes two seconds and doesn't conflict with anything. Many people don't use editorconfig, and I imagine that number is getting even lower with the rise of prettier.

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

Yeah, I think it's pretty easy to add by hand and we don't want to make decisions like this for our users.

@gaearon gaearon closed this as completed Jan 9, 2018
@alamothe
Copy link

Shouldn't it work the other way round? Meaning, CRA should respect existing .editorconfig

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants