Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis for created apps #365

Closed
Jiansen opened this issue Aug 4, 2016 · 9 comments
Closed

Add Travis for created apps #365

Jiansen opened this issue Aug 4, 2016 · 9 comments

Comments

@Jiansen
Copy link
Contributor

Jiansen commented Aug 4, 2016

In addition to local Jest test, I think it is still useful to include .travis.yml in the generated app. For example, like CRA, the app could be built and tested in both Node 4 and 6 for every pushed commit.

Travis is harmless for users who don't want to use it.

@ryanyogan
Copy link

You are correct on CRA using travis: https://github.com/facebookincubator/create-react-app/blob/master/.travis.yml as an open source project.

I think it would be a tad too opinionated to push a CI service on an individual as there are many other providers. Travis is awesome for open source however many tend to utilize other services due to the cost of Travis for personal projects.

Just my .02

@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

Yea, we won't be doing this. You can always add it yourself, and it's indeed too opinionated. Thanks for the suggestion though!

@gaearon gaearon closed this as completed Sep 2, 2016
@vjeux
Copy link
Contributor

vjeux commented Sep 2, 2016

@gaearon would be nice to put an entry in the readme on how to setup travis. Should be pretty easy

@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

Agree now that we have testing.
@Jiansen Would you like to work on a PR adding this doc note?

@rogeliog
Copy link
Contributor

rogeliog commented Sep 2, 2016

@vjeux I like the idea of a CI section, where it could eventually show how to setup different CI services(similar to the deployment section). I'm more than happy to help with this one :)

@rogeliog
Copy link
Contributor

rogeliog commented Sep 2, 2016

Oops sorry :( I posted my comment a minute after @gaearon... If @Jiansen is planning on working on this then that sounds great also! :) :)

@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

@rogeliog Issue is pretty old so I think it’s fine if you take it. 👍 If @Jiansen is also interested, they can express their interest here later and maybe collaborate.

@Jiansen
Copy link
Contributor Author

Jiansen commented Sep 2, 2016

@gaearon , I am happy to adding Travis set up process to a doc note.

@rogeliog , if you wanted to take it and/or add process of setting up other CIs, I am sure it will be very useful for some users. Just let me know if you may want me to work on the note for Travis.

@rogeliog
Copy link
Contributor

rogeliog commented Sep 5, 2016

@Jiansen, yeah, if you want to add the note for Travis I think that it makes sense and you should take it 😄 that is more than fine with me 👍 We can worry about adding notes for other CIs when the need comes :)

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants