-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay launch editor in Webstorm 2017.3.2 does not work #3662
Comments
I couldn't reproduce this behavior with Webstorm 2017.3.2. Also, it seems Webstorm does work without specifying workplace as far as
|
@tharakawj thanks for having a look. If I use the relative path Indeed, if I use the absolute path of the file, it works. |
If the command with relative path doesn't work, I think there is a problem in your setup. Are you always using the full path to the webstorm application without creating Command Line Launcher? Then probably that's the issue. If |
@tharakawj Yes, that was it. Many thanks! |
Is this a bug report?
Yes.
The launch editor functionality does not work for Webstorm 2017.3.2.
As per Webstorm docs, the command should specify the workspace too.
After some debugging, I saw the https://github.com/facebookincubator/create-react-app/blob/4434467a438c3d431a5169038a5f481bbf763efe/packages/react-dev-utils/launchEditor.js#L130 initialization, and I don't see anywhere where the variable is reinitialized.
Can you also reproduce the problem with npm 4.x?
Yes. Current version I'm using is 4.2.0
Which terms did you search for in User Guide?
The only relevant description can be found in the Advanced Configuration, therefore the
REACT_EDITOR
- which I didn't override.Environment
node -v
:v7.10.1
npm -v
:4.2.0
yarn --version
(if you use Yarn):1.3.2
npm ls react-scripts
(if you haven’t ejected):Then, specify:
Steps to Reproduce
Expected Behavior
Relevant file is opened in Webstorm.
Actual Behavior
Many thanks!
The text was updated successfully, but these errors were encountered: