-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce installed size in 2.x #3880
Comments
As far as new dependencies go:
As far as updates:
|
It's unfortunate that It would be really nice to have some kind of build size and install size check that ran automatically along with the other tests. Something like: https://github.com/apps/buildsize |
Cold or warm build? First build will be slower because we compile |
@iansu I plan to update JSDOM soon, issue is already opened smooth-code/h2x#8 |
Done, you can upgrade to v1.9.2, it uses the last version of JSDOM and the version is not fixed. So it should solve your problem. |
@neoziro That's great! Thank you. I'll make a PR to update this right away. |
I took a quick look and svgr and jest 22/23 seem to be the biggest culprit as they contribute ~15MB of unique dependencies in the latest build (probably thanks to jsdom) |
I think we can downgrade inquirer to 3.3.0 as it doesn't have rxjs dependency. |
I hope svgr is now sharing the same JSDOM as Jest. |
Yep:
|
svgr also has a dependency on prettier @neoziro |
Hmm yes, it is not required for webpack usage but it is for CLI, I have to think about it. It will probably come with the v2, i plan to move into a Lerna architecture. It will be easier to do it. |
@bugzpodder nwsapi 2.0.0 had accidentally been published without an |
FYI, you can visualize npm install size over time with Package Phobia 👍 For example create-react-app@2.0.0-next.b2fd8db8 Update: I realize now you were refering to react-scripts, d'oh 😆 |
I noticed 2.x has regressed on the installed size
Before:
After:
You can check by creating a project with 2.0 alpha: #3815.
@wtgtybhertgeghgtwtg Is this something you could look into?
The text was updated successfully, but these errors were encountered: