Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After run yarn eject #4310

Closed
givingwu opened this issue Apr 16, 2018 · 1 comment
Closed

After run yarn eject #4310

givingwu opened this issue Apr 16, 2018 · 1 comment

Comments

@givingwu
Copy link

givingwu commented Apr 16, 2018 •
edited
Loading

After yarn eject the package.json be changed but the all dependencies be inserted to "dependencies" , not "devDependencies".

It is wrong? right?

i already known it does not influence the bundle.js if i do not import any package under development environment, but it was not comfortable on right way. Many packages was belong to development environment but it shown in dependencies in package.json.
@bondz
Copy link
Contributor

bondz commented Apr 16, 2018 •
edited
Loading

This has been asked before, see #2657, #2696, #1764, and #3220

Basically, it is like that because some hosts don't install devDependencies on deployments.

You can move the modules back to devDependencies if you want except for react, react-dom, and polyfills used by CRA

@iansu iansu closed this as completed Apr 16, 2018
@ghost ghost mentioned this issue Apr 17, 2018
Closed
@yezihaohao yezihaohao mentioned this issue Jul 4, 2018
Closed
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iansu @bondz @givingwu