Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-react-app@2.1.0 has incorrect peer dependency "babel-eslint@^7.2.3". #4463

Closed
ghost opened this issue May 15, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented May 15, 2018

I am installing "eslint-config-react-app": "^2.1.0" and when I do, i get this warning:

warning " > eslint-config-react-app@2.1.0" has incorrect peer dependency "babel-eslint@^7.2.3".
warning " > eslint-config-react-app@2.1.0" has unmet peer dependency "eslint-plugin-jsx-a11y@^5.1.1".

Is this is create-react-app issue, or a yarn issue?
Thx.

@romandecker
Copy link

Confirmed, I get the same thing. babel-eslint >= 8 seems to work just fine, can we bump the peerDependency?

@kadamwhite
Copy link

The next release should address this, looking at this file on the next branch I can see that both packages have gotten version bumps. babel-eslint is 8.2.2 (since #3522), and eslint-config-jsx-a11y is 6.0.2 (since #2690). It'd be up to @gaearon to confirm but I think we should expect this issue to be resolved when the new version is released, which I hope will be soon!

@bugzpodder
Copy link

Yep this should be resolved in CRA 2.

@facebook facebook locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants