Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix silly warning #5034

Closed
Timer opened this issue Sep 19, 2018 · 0 comments
Closed

Fix silly warning #5034

Timer opened this issue Sep 19, 2018 · 0 comments
Labels
issue: bug
Milestone
2.0

Comments

@Timer
Copy link
Contributor

Timer commented Sep 19, 2018 

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
@Timer Timer added this to the 2.0.0 milestone Sep 19, 2018
Timer added a commit to Timer/create-react-app that referenced this issue Sep 20, 2018
@Timer
Always lint with latest React version
dd39f85 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default and warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
@Timer Timer mentioned this issue Sep 20, 2018
Merged
Timer added a commit to Timer/create-react-app that referenced this issue Sep 20, 2018
@Timer
Always lint with latest React version (facebook#5043)
4abc5c4 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
zmitry pushed a commit to zmitry/create-react-app that referenced this issue Sep 30, 2018
@Timer
Always lint with latest React version (facebook#5043)
42e5669 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
LishuGupta652 pushed a commit to LishuGupta652/create-react-app-1 that referenced this issue Oct 8, 2024
@Timer
Always lint with latest React version (facebook#5043)
f474b85 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Timer