-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last call for Create React App v2 #5103
Comments
react-scripts
v2
I'm a bit late to the party. What do you mean with " |
I reworded to
Does this make more sense? |
|
Thanks @gaearon, I was about to ask the same thing ^.^ I don't think I've ever needed it, but I guess it's nice it's there. Maybe this'll help build proper "goto definition" functionality, right now it keeps jumping to compiled js, and it's a mess. |
Yes. Thanks Dan! |
I think there is some kind of misunderstanding here. Previously, if somebody published a package that used newer syntax like |
Have an issue with
Actually, there was pretty extensive amount of options for proxy, are they all gone? With |
@Z-AX this is not a bug -- we removed the proxy options. Please read the migration instructions above. 😄 |
Good job everyone working on wrapping up the 2.0 release! Thanks for your efforts! |
@Timer I don't see it in docs right here and it was working with the most recent alpha. Edit: see it in Roadmap, don't see new docs on this. |
Are you planning on getting the typescript PR in or will that come in a minor update post 2.0 release? |
Have an errors when using flow in node_modules packages (using yarn workspace) |
@meafmira support for workspaces was dropped. Please see the migration instructions (we know they're not great, but we'll be improving them). |
@Timer thanks, everything seems working. Btw, is it something on my side that chunk 1 has content like this? As I can remember, always had this one on build, for maybe a year or so: |
Have errors when using flow in node_modules packages and socket.io |
Please file an issue with more details @sumitsg10 and a reproducible demo. @Z-AX naming is pretty arbitrary and actually caused really bad behavior for larger apps. I don't think anyone but you (the developer) will ever notice. :-) |
I don't think it's expected for Flow to work inside |
Just a question: Why use |
@lixiaoyan see the above message from @gaearon, the same reasoning applies |
Yup, |
Another thing worth trying is to delete |
@gaearon oops, I think there were a few things going wrong, so I couldn't reproduce the error now. In some terminals, I forgot to switch from node 6 to node 10. There might have been modules I installed with npm 3 when I reported the issue. Then I switched to node 10, removed node_modules completely (I must do this) and reran the test, it's all working now. Sorry for the confusion. |
Hi, we have tried to upgrade to the new version CRA2, but was impossible... we have found errors with decorators (we use MobX), eslint issues and react-toolbox. Previously we have been using react-rewired... We will read carefully the documentation again. We have solved many issues (like eslint dependecies version, removing the node_modules folder). I have some questions... can we use CRA v2 with decorators without react-rewired? Thanks. |
@chemitaxis you can use this https://github.com/arackaf/customize-cra. |
yo try make it less configurable and more dogmatic |
If you open
Additionally, it says:
Therefore you shouldn't be surprised that following migration instructions doesn't work for you. That's what you agreed to when you started using
Indeed you can try this although just like The reason we don't allow using decorators is because they're an unstable feature, and in fact it has already just changed its semantics. This means your old code using decorators won't work with the new syntax — unless all the libraries you depend on figure out a way to support both syntaxes. Additionally, there are more syntax changes planned for decorators. This is why we'll keep them disabled. |
What's the advised way to import Markdown files into CRA? Before I used Or could I use |
@weyert Yeah |
Hi everyone! We just released |
So what about TypeScript built-in support? |
Thanks @gaearon and sorry... my mistake. We are replacing all our decorators (@Observers). I will be back and I will give you feedback... |
@borisowsky We didn't say TypeScript would be coming in 2.0 anywhere. That said it's likely we'll add something in 2.x. |
Upgrading an app created with 1.1.3, no issues when upgrading
|
Sorry, that sounds like a Yarn failure so we can't help with it. |
@gaearon okay, I mention it though because I didn't have this issue before I upgraded |
Looks like there is a new release of eslint@5.6.1 that CRA is complaining about if you have eslint installed local. |
I mean, in general we never supported installing |
I know this is the official stance and this discussion should take place elsewhere but I think many people who are using CRA in a production / semi-production setup use |
I understand where you're coming from — I'm not saying we're opposed on principle but I'm saying that it has always caused hard-to-debug issues like this due to how ESLint doesn't allow presets to encapsulate their plugins. ESLint plans to fix this in ESLint 5 so that will solve the issue permanently. In the meantime, we want to warn our users that when they do something like this, our setup can break. Again, you can ignore our warning, just as the warning says. Or maybe we're talking about different things. Did you notice the warning provides instructions for how to turn it off at the bottom? |
I've followed the instructions from the proxy migrations but they don't work for me, i've installed the |
@R4z1ell Please file a new issue. |
Hi everyone! We just released what we hope to be the last beta before v2 is marked stable and tagged
latest
on npm tomorrow.Please try it as soon as possible and let us know if you run into any issues!
Create new application:
Upgrade existing:
$ npm install react-scripts@next --save $ # or $ yarn add react-scripts@next
Here's a draft of the release notes:
Create React App v2.0.1
New Features
node_modules
now workMigrating from 1.1.15 to 2.0.1
Inside any created project that has not been ejected, run:
$ npm install --save --save-exact react-scripts@2.0.1 $ # or $ yarn add --exact react-scripts@2.0.1
Next, follow the migration instructions below that are relevant to you.
You may no longer code split with
require.ensure()
We previously allowed code splitting with a webpack-specific directive,
require.ensure()
. It is now disabled in favor ofimport()
.To switch to
import()
, follow the examples below:Single Module
Multiple Module
The default Jest environment was changed to
jsdom
Look at the
test
entry in thescripts
section of yourpackage.json
.Here's a table how to change it from "before" and "after", depending on what you have there:
react-scripts test --env=jsdom
react-scripts test
react-scripts test
react-scripts test --env=node
.mjs
file extension support was removedChange the extension of any files in your project using
.mjs
to just.js
.It was removed because of inconsistent support from underlying tools. We will add it back after it stops being experimental, and Jest gets built-in support for it.
Move advanced proxy configuration to
src/setupProxy.js
This change is only required for individuals who used the advanced proxy configuration in v1.
To check if action is required, look for the
proxy
key inpackage.json
. Then, follow the table below.proxy
key inpackage.json
proxy
is a string (e.g.http://localhost:5000
)proxy
is an objectIf your
proxy
is an object, that means you are using the advanced proxy configuration.Again, if your
proxy
field is astring
, e.g.http://localhost:5000
, you do not need to do anything. This feature is still supported and has the same behavior.First, install
http-proxy-middleware
using npm or Yarn:$ npm install http-proxy-middleware --save $ # or $ yarn add http-proxy-middleware
Next, create
src/setupProxy.js
and place the following contents in it:Now, migrate each entry in your
proxy
object one by one, e.g.:Place entries into
src/setupProxy.js
like so:You can also use completely custom logic there now! This wasn't possible before.
Internet Explorer is no longer supported by default (but you can opt in!)
We have dropped default support for Internet Explorer 9, 10, and 11. If you still need to support these browsers, follow the instructions below.
First, install
react-app-polyfill
:$ npm install react-app-polyfill --save $ # or $ yarn add react-app-polyfill
Next, place one of the following lines at the very top of
src/index.js
:You can read more about these polyfills here.
The behavior of a CommonJS
import()
has changedWebpack 4 changed the behavior of
import()
to be closer in line with the specification.Previously, importing a CommonJS module did not require you specify the default export. In most cases, this is now required.
If you see errors in your application about
... is not a function
, you likely need to update your dynamic import, e.g.:Anything missing?
This was a large release, and we might have missed something.
Please file an issue and we will try to help.
Migrating from 2.0.0-next.xyz
If you used 2.x alphas, please follow these instructions.
Detailed Changelog
>> TODO <<
The text was updated successfully, but these errors were encountered: