Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out 2.x CodeSandbox story #5128

Closed
gaearon opened this issue Sep 27, 2018 · 10 comments
Closed

Figure out 2.x CodeSandbox story #5128

gaearon opened this issue Sep 27, 2018 · 10 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2018

cc @CompuIves we're getting really close to releasing 2.0.0 of react-scripts, how can we make sure it works great on CodeSandbox?

@Timer Timer added this to the 2.0.0 milestone Sep 27, 2018
@CompuIves
Copy link

Hey, thanks for letting me know! I can set up a testing sandbox of our CRA v2 implementation on staging today or tomorrow. It would also be good to know when you're going to release exactly so we can have our side updated in time.

If you're actually planning on releasing tomorrow I can try to get one on staging today 🙂.

@gaearon
Copy link
Contributor Author

gaearon commented Sep 27, 2018

@Timer your call

@Timer
Copy link
Contributor

Timer commented Sep 27, 2018

I feel confident about shipping to latest tomorrow. Either way, if the template restores under ^2.0.0 it'll continue getting updates anyway.

@CompuIves
Copy link

Working on CRA v2 support now. Hope to have something in the next hour.

@Timer
Copy link
Contributor

Timer commented Sep 28, 2018

Great! We just shipped react-scripts@2.0.1, so we're getting really close. 😄

@CompuIves
Copy link

Here's the PR: codesandbox/codesandbox-client#1124
Here's a test sandbox: http://pr1124.cs.lbogdan.tk/s/z3rwnzm6p4

@Timer
Copy link
Contributor

Timer commented Sep 29, 2018

Punting this to 2.x since it's pretty much figured out and doesn't need to block immediate 2.0.0 release.

Let me know if you disagree.

@Timer Timer modified the milestones: 2.0.0, 2.x Sep 29, 2018
@gaearon
Copy link
Contributor Author

gaearon commented Sep 29, 2018

Sure

@Timer Timer modified the milestones: 2.x, 2.0.x Oct 1, 2018
@CompuIves
Copy link

I think we can close this one as we deployed v2 support: https://codesandbox.io/s/new

@bugzpodder
Copy link

Thanks!

@Timer Timer modified the milestones: 2.0.x, 2.0.4 Oct 3, 2018
@lock lock bot locked and limited conversation to collaborators Jan 10, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants