Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide empty mock for http2 module #6161

Closed
kjin opened this issue Jan 9, 2019 · 1 comment
Closed

Provide empty mock for http2 module #6161

kjin opened this issue Jan 9, 2019 · 1 comment

Comments

@kjin
Copy link
Contributor

kjin commented Jan 9, 2019

I've opened a PR to add http2 as a core module in #5686, would love to see it landed as it seems that a lot of people are running into this problem. Thanks!

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

http2

Environment

System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Binaries:
Node: 8.9.3 - ~/.nvm/versions/node/v8.9.3/bin/node
Yarn: 1.3.2 - /usr/local/Cellar/node/7.0.0/libexec/npm/bin/yarn
npm: 5.5.1 - ~/.nvm/versions/node/v8.9.3/bin/npm
Browsers:
Chrome: 71.0.3578.98
Safari: 12.0.2
npmPackages:
react: Not Found
react-dom: Not Found
react-scripts: Not Found
npmGlobalPackages:
create-react-app: Not Found

Steps to Reproduce

  1. See Module 'http2' not found grpc/grpc-node#610

Expected Behavior

It doesn't crash

Actual Behavior

It crashes

Reproducible Demo

N/A

@Timer
Copy link
Contributor

Timer commented Jan 9, 2019

Closing in favor of PR. Thanks.

@Timer Timer closed this as completed Jan 9, 2019
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants