Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a readme to react-scripts and create-react-app packages #690

Closed
fson opened this issue Sep 20, 2016 · 2 comments
Closed

Add a readme to react-scripts and create-react-app packages #690

fson opened this issue Sep 20, 2016 · 2 comments
Milestone

Comments

@fson
Copy link
Contributor

fson commented Sep 20, 2016

The create-react-app package on npm doesn't have a README associated with it: https://www.npmjs.com/package/create-react-app

The react-scripts package has the main README on npm, but I think it won't have it in the monorepo configuration unless we create one in that package folder.

I think we could keep publishing the default README to react-scripts by changing the release script so that it copies it over, or just make a shorter README for each package where we just explain what it is an link back to the main project.

@gaearon
Copy link
Contributor

gaearon commented Sep 20, 2016

make a shorter README for each package where we just explain what it is an link back to the main project.

This makes sense to me and sounds fairly simple.

@gaearon gaearon added this to the 0.5.0 milestone Sep 20, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Fixed by 92afcaf.

@gaearon gaearon closed this as completed Sep 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants