Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Hosted workbox version #7678

Closed
sidati opened this issue Sep 13, 2019 · 5 comments
Closed

Self-Hosted workbox version #7678

sidati opened this issue Sep 13, 2019 · 5 comments

Comments

@sidati
Copy link

sidati commented Sep 13, 2019

Is your proposal related to a problem?

We need to use a self-hosted version of workbox, we don't want Google to track our traffic 😄

Describe the solution you'd like

Use workbox npm packages

@heyimalex
Copy link
Contributor

Hm, maybe setting importWorkboxFrom from cdn to local would fix this, at the expense of bundle size.

@sidati
Copy link
Author

sidati commented Sep 17, 2019

Yeah @heyimalex, that should do it once this one #5369 is merged, hopefully soon 😅

@silverwind
Copy link

silverwind commented Oct 13, 2019

Setting local works but that creates the workbox files in its own directory build/workbox-v4.3.1 meaning they are not bundled or cached by the service worker itself which hurts performance.

I'm thinking workbox (and service worker) should be opted-in as a dependency and if present, should be bundled like any other module. Similar to how Sass is also opted in via adding it as a dependency.

@jeffposnick
Copy link
Contributor

This should be closed by #9205, which will go live as part of c-r-a v4.

@sidati
Copy link
Author

sidati commented Aug 19, 2020

Thanks @jeffposnick

@sidati sidati closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants