-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript parsing error when EXTEND_ESLINT=true #7855
Comments
I'm having what appears to be the same issue - I'm trying to enable some linting rules in an existing CRA app, and as soon as I put the EXTEND_ESLINT param in (through either the .env file, or inline to the start command like
The same as @ae2438 when I take that out, the application compiles and runs just fine. I've had success adding linting rules in to the package.json file that validate fine when I run |
This could be the source of the problem. It seems that a parser is selected at the beginning of the linting and then ignores the Consider the following
where Tests:
Headings:
Results:
(I hope all that makes sense...) Conclusion: The expected results should be "parser not found" errors in all columns except the last column, where both parsers are valid. |
To clarify, this seems to all be because of #7776 |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Hello, any movement on this? It's the only thing preventing me having really clean ReasonML-TypeScript-JavaScript interop with CRA |
@christianchown check #7776. It says it's in the 3.3 milestone |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. |
Describe the bug
Originally asked on Stackoverflow
Here is a demonstration.
See the above question for more info. Essentially, I get parsing errors when using various Typescript features if I set
EXTEND_ESLINT
in my.env
. Removing this line allows the app to compile just fine, but of course I lose the ability to configure ESLint. The problem occurs in a newly created CRA project that has then had Typescript installed after creation.I have had some luck by changing
index.js -> index.tsx
, however, this leads to other ESLint problems that are not really ideal.Did you try recovering your dependencies?
No need. This happens in a newly created project with very few new dependencies.
Which terms did you search for in User Guide?
The Stackoverflow question lists some of the tutorials/documentation I followed.
Environment
Steps to reproduce
yarn start
oryarn vstart
to run without customize-craExpected behavior
The app compiles. ESLint gives appropriate errors/warnings.
Actual behavior
App does not compile. A parsing error is raised by ESLint (?)
Reproducible demo
https://github.com/ae2438/cra-test
The text was updated successfully, but these errors were encountered: