Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immer dependency in react-dev-utils is outdated and needs to be updated #8750

Closed
markerikson opened this issue Mar 30, 2020 · 3 comments · Fixed by #8933
Closed

Immer dependency in react-dev-utils is outdated and needs to be updated #8750

markerikson opened this issue Mar 30, 2020 · 3 comments · Fixed by #8933

Comments

@markerikson
Copy link

Describe the bug

The react-dev-utils package currently depends on immer@1.10.0:

That version is extremely outdated, since Immer is now at v6.x:

https://github.com/immerjs/immer/releases

Since many apps now use Immer (including those built with Redux Toolkit), this can lead to multiple versions of Immer being included in node_modules. In at least one instance, it resulted in a weird situation where the RTK-requested immer@6 dependency was nested while the react-dev-utils-requested immer@1.10.0 version was hoisted, and then TS failed to compile the user's project:

reduxjs/redux-toolkit#459

Given that Immer's API has basically stayed the same and that it's only being used in one spot in react-dev-utils, this should be an easy upgrade.

@stale
Copy link

stale bot commented Apr 29, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Apr 29, 2020
@markerikson
Copy link
Author

ping

@iansu
Copy link
Contributor

iansu commented Jul 22, 2020

Fixed in #8933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants