-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support template sources outside of npmjs.com #8844
Comments
Hi @andredigenova, I have the same problem. Your issue is similar the issue #8425. I did all set up for private npm, but not working. |
I discovered the problem. The template path within node_modules was not being found. I made the pull request with the following adjustment: javascript: create-react-app/packages/react-scripts/scripts/init.js befor: const templatePath = path.dirname( require.resolve(${templateName}/package.json, { paths: [appPath] }) ); after: const templatePath = path.dirname( require.resolve(${templateName}/package.json, { paths: [${appPath}/node_modules] }) ); |
Hi @andredigenova, This should work fine with third-party registries. I use it with Verdaccio on a work-related project. Can you please share your template? Also, note that templates are required to have a |
With field "main" in package.json worked. |
Thanks for the update! I'll close this off. Sorry again, we'll get the fix out ASAP. |
Is your proposal related to a problem?
Using create-react-app templates outside of the npmjs.com ecosystem is painful. It seems the only viable way to do it is pull the code down yourself and use the file: syntax, or host a tarball somewhere.
This is fairly important for template code bases that are private since there doesn't appear to be a no-cost way of hosting private packages on npmjs.com.
Describe the solution you'd like
There are a couple solutions to this and I think both of them would be universally useful.
I'm sure there are probably others I didn't think of.
Describe alternatives you've considered
Setting a 3rd-party npm package registry on npm globally before running npx create-react-app seems to be broken. I tested it with Github's npm registry and it failed with an odd error part way through project setup.
All variations of git URI syntax I've tried don't seem to work and produce errors mostly related to cra-template getting injected when it shouldn't be.
Additional context
(Write your answer here.)
The text was updated successfully, but these errors were encountered: