-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erroneous CSS optimization #9268
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Wow - no response, and then marked as stale due to inactivity even though that inactivity is not the fault of the reporter. Sublime! |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
And again - is there something missing from my report? Can I provide something else? Am I reporting in the wrong place? I understand you need. to attend to a multitude of issues, but you have not said a word - and I don't mean "given a resolution", I literally mean "said anything" - for over 2 months now, during which time I have not been able to publish my project properly due to someone else's error. This is lamentable. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
You can mark it as stale as many times as you want - I won't relent until I get a human to respond in a satisfactory manner. |
Issue is still valid. I'll make such a notation here every other week so Mr. StaleBot doesn't get any clever ideas... |
3 similar comments
Issue is still valid. I'll make such a notation here every other week so Mr. StaleBot doesn't get any clever ideas... |
Issue is still valid. I'll make such a notation here every other week so Mr. StaleBot doesn't get any clever ideas... |
Issue is still valid. I'll make such a notation here every other week so Mr. StaleBot doesn't get any clever ideas... |
Can you try the latest release and see if this is still an issue? |
Yes sir, will do. |
Sorry for the delay. current version of create-react-app: 4.0.3 Then I ran the code under the following conditions:
So problem is still present. |
I have just landed on this: #10015 |
The issue was tracked to Is there something I can do on my side to upgrade to the latest package? (everything was set up using |
Any news on updating the package? |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Preface
First of all, I'd like to apologize if this issue is not related to
create-react-app
itself. Please redirect me to the proper package if it isn't. I am not particularly knowledgeable when it comes to packages and setup.Describe the bug
When creating an optimized build (
npm build
) I get erroneous CSS optimization (I assume "something" is optimizing incorrectly, but I have no idea what). This does not reproduce when simply running locally throughnpm start
.This is the CSS in question:
it gets optimized into:
which may seem correct at first, except
border-width
can be a set of values for the different "sides" of the border, and that does not work with the shorthand. (border: 20px 0 30px 0 solid red
is not valid, for instance). So the properties should not be getting aggregated. At least as far as my understanding goes.Environment
current version of create-react-app: 3.4.1
System:
OS: Windows 10 10.0.19041
CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
Binaries:
Node: 8.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 44.19041.1.0
Internet Explorer: Not Found
npmPackages:
react: ^16.12.0 => 16.13.1
react-dom: ^16.12.0 => 16.13.1
react-scripts: 3.4.1 => 3.4.1
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce
In "description". Essentially:
border-width
andborder-color
.border-width
to represent multiple "sides" (10px 20px 0 30px
).npm start
. Observe correct CSS.npm build
. Observe incorrect CSS.For brevity, here's how to do step 2:
Reproducible demo
You can find my published, erroneously optimized page here:
https://protos.now.sh
Inspect any "input" and you'll see the CSS is incorrect.
The text was updated successfully, but these errors were encountered: