-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Use new runtime by default or fix the detection #9822
Comments
IMHO the detection is fine - it solves more problems than it creates. As mentioned in the other thread - I believe that if pragmas alone would reconfigure the transform then there wont be a problem here. We would eat the cake and have it too 😉 |
Just waiting for some more thoughts from the team on this, but we could leave the automatic detection on - with a manual "emergency" flag, as we know it may fail in some cases (where there are mixed React versions installed). Another option may be to move back to the previous logic, and find another way to resolve the Jest issue - maybe an environment variable that we set in |
We definitely need an opt-out flag. For detection, if we leave it in — it needs to resolve React from the application folder (and not from |
I think I addressed all these issues in #9861 |
I'm starting to think that automated detection might be a significant footgun. At least when done this way. https://github.com/facebook/create-react-app/pull/9788/files#r506932998
I'm leaning towards this proposal:
This also addresses automatic detection issues in facebook/react#20031 (comment).
The text was updated successfully, but these errors were encountered: