Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install React, ReactDOM and React-Scripts at the same time #1253

Merged
merged 8 commits into from
Feb 23, 2017
Merged

Install React, ReactDOM and React-Scripts at the same time #1253

merged 8 commits into from
Feb 23, 2017
+97 −54

Commits on Feb 14, 2017

  1. Install react and react-dom along with react-scripts 

    - Install react, react-dom and react-script in a same time
- Move react-scripts to devDependencies.
    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    1d863b0 View commit details
    Browse the repository at this point in the history

  2. Check if react, react-dom has been already installed 

    - To backward compatibility with old CRA’s cli
- In case old CRA doesn’t install react, react-don along with
react-scripts
    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    545b0ab View commit details
    Browse the repository at this point in the history

  3. Use packageName to find script dependency 

    - use packageName to find dependency
- fix pathExists.sync
    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    b84eab6 View commit details
    Browse the repository at this point in the history

  4. Check dependencies.react in package.json instead of actual files

    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    80e1738 View commit details
    Browse the repository at this point in the history

  5. Process exit when dependencies not found 

    - Show error and exit when dependencies not found.
- Log install show custom package name
    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    ed11c7a View commit details
    Browse the repository at this point in the history

  6. Remove template string

    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    423dd1a View commit details
    Browse the repository at this point in the history

  7. Install dependencies if template is preseted

    @n3tr
    n3tr committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    9a7f059 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2017

  1. Remove dangling comma

    @Timer
    Timer committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    c59a318 View commit details
    Browse the repository at this point in the history