Add eslintConfig to new projects automatically #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We actually used to do this in the past, but there were issues with editors not finding the config since it was a deeper dependency. We now switched away from I would hold off until we officially stop supporting npm 2. |
|
Is this worth doing if we detect the Node version to be >= 6? Or would we be concerned about project portability between team members then? |
|
@gaearon what would you suggest for the resolve of this PR? Should I close it or should I push further in a direction? |
|
I think we can do it—let's revisit this next time we look at cutting a minor release. |
|
We were worried about npm 2 in 2017? Gee, how time flies... |
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Sep 21, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the eslintConfig to automatically be injected into the package.json rather than having to go the extra step and copy/paste it manually.