backup and restore .npmignore #1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@wtgtybhertgeghgtwtg @EnoahNetzach could you please check this? btw. Travis fails because of this #1461 |
|
@tuchk4 I don't sincerely know, I personally run tests on a docker container.. |
|
@EnoahNetzach the problem is that after running test git directory is not clean - deleted |
|
Seems this PR is not needed after E2e jsdom fix #1470 was merged becasue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time after tests - there is deleted
.npmignoreandgit statusis not clean.Backup and restore
.npmignoreas well aspackgae.json.@EnoahNetzach could you please check it? Do we really need it?
If yes - I am not sure about where should be code to restore.
Now at
cleanupfunction but maybe it could be placed earlier during script execution