Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build exit with error code when interrupted #1496

Merged
merged 7 commits into from
Feb 11, 2017

Commits on Feb 7, 2017

  1. Make build exit with error code when interrupted

    This addresses issue facebook#1493.
    
    Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code.
    brandones committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    72750e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af8559c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2017

  1. Don't catch SIGINT

    Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise.
    brandones committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    6520b8c View commit details
    Browse the repository at this point in the history
  2. Style fix

    brandones committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    29440b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2017

  1. No changes needed to build.js

    Problem is coming from the parent process, `react-scripts`
    brandones committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    db146ab View commit details
    Browse the repository at this point in the history
  2. Make react-scripts script handle signals

    Brandon Istenes committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    e749258 View commit details
    Browse the repository at this point in the history
  3. Clarify context

    Timer committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    4750386 View commit details
    Browse the repository at this point in the history