Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build exit with error code when interrupted #1496

Merged
merged 7 commits into from
Feb 11, 2017
Merged

Make build exit with error code when interrupted #1496

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72750e6
Make build exit with error code when interrupted
brandones Feb 7, 2017
af8559c
Better error messages for kill signals
brandones Feb 7, 2017
6520b8c
Don't catch SIGINT
brandones Feb 9, 2017
29440b7
Style fix
brandones Feb 9, 2017
db146ab
No changes needed to build.js
brandones Feb 10, 2017
e749258
Make react-scripts script handle signals
Feb 10, 2017
4750386
Clarify context
Timer Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/react-scripts/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,3 +233,25 @@ function copyPublicFolder() {
filter: file => file !== paths.appHtml
});
}

var signals = [
{
name: 'SIGINT',
code: 2,
message: 'This usually means someone pressed Ctrl+C.'
},
{
name: 'SIGTERM',
code: 15,
message: 'This could mean someone that killed the process (e.g. with ' +
'`kill -15` or `killall`), that the system is shutting down, or that ' +
'it ran out of memory.'
}
];

signals.forEach(function (signal) {
process.on(signal.name, function () {
console.log('ERROR: Build stopped by ' + signal.name + '. ' + signal.message);
Copy link
Contributor

@Timer Timer Feb 8, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add another field for severity? If it's killed with SIGINT we should probably say INFO or WARN(ING) instead of ERROR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard this, @gaearon wishes Ctrl+C exit silently.

process.exit(signal.code);
});
});