Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds HOST and PORT env variables to react app so websocket #1588

Closed
wants to merge 2 commits into from
Closed

Adds HOST and PORT env variables to react app so websocket #1588

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
532b463
Adds HOST and PORT env variables to react app so websocket can use th…
scisci Feb 18, 2017
c4daa1c
Merge branch 'master' into master
Timer May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-dev-utils/webpackHotDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ function destroyErrorOverlay() {
// Connect to WebpackDevServer via a socket.
var connection = new SockJS(url.format({
protocol: window.location.protocol,
hostname: window.location.hostname,
port: window.location.port,
hostname: process.env.HOST || window.location.hostname,
port: process.env.PORT || window.location.port,
// Hardcoded in WebpackDevServer
pathname: '/sockjs-node'
}));
Expand Down
7 changes: 6 additions & 1 deletion packages/react-scripts/config/env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ function getClientEnvironment(publicUrl) {
// For example, <img src={process.env.PUBLIC_URL + '/img/logo.png'} />.
// This should only be used as an escape hatch. Normally you would put
// images into the `src` and `import` them in code to get their paths.
'PUBLIC_URL': publicUrl
'PUBLIC_URL': publicUrl,
// Useful for allowing the hot dev websocket to connect to the host
// specified in the env file, instead of window.location, which could
// be wrong if the dev server is being proxied.
'HOST': process.env.HOST || '',
'PORT': process.env.PORT || ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can we make this not introduce additional environment variables?
Can we inject this code into the bundle elsehow?
We can use some black-boxed logic/variables since they'll be references from react-dev-utils and not the application itself.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it needs to be configured somehow. The .env file was the only place that I knew of that allowed this, that's why I chose to put it there.

I wasn't aware that variables could be shared in another way but if you point me in the direction of an example I could change this.

});
// Stringify all values so we can feed into Webpack DefinePlugin
var stringified = {
Expand Down