From 6f3ed0703d9c90a759c5dd153ba54a70ec1eed6a Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 16:35:01 -0800 Subject: [PATCH 1/8] updating eslint to 3.16.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 63f413e4d6d..97f2ec07a02 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ }, "devDependencies": { "babel-eslint": "7.1.0", - "eslint": "3.8.1", + "eslint": "3.16.1", "eslint-config-react-app": "0.5.1", "eslint-plugin-flowtype": "2.21.0", "eslint-plugin-import": "2.0.1", From c172599f9e67fab95b01bfa06e91389138598c03 Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 16:38:18 -0800 Subject: [PATCH 2/8] add support for ignoreRestSiblings in eslint http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings --- packages/eslint-config-react-app/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index f6dd412261f..f4d33baffa3 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -134,7 +134,8 @@ module.exports = { 'no-unused-vars': ['warn', { vars: 'local', varsIgnorePattern: '^_', - args: 'none' + args: 'none', + ignoreRestSiblings: true, }], 'no-use-before-define': ['warn', 'nofunc'], 'no-useless-computed-key': 'warn', From ab927889d5aa3dfa4d61a261adb003e54bb493a7 Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 17:04:21 -0800 Subject: [PATCH 3/8] updating eslint to 3.16.1 in `react-scripts` --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 1bc9e053f5a..137956e06c1 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -37,7 +37,7 @@ "css-loader": "0.26.1", "detect-port": "1.0.1", "dotenv": "2.0.0", - "eslint": "3.8.1", + "eslint": "3.16.1", "eslint-config-react-app": "^0.5.2", "eslint-loader": "1.6.3", "eslint-plugin-flowtype": "2.21.0", From 059b6e7a5ac738f318b462a413afa8295e49bede Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 17:06:40 -0800 Subject: [PATCH 4/8] updating eslint --- packages/eslint-config-react-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/package.json b/packages/eslint-config-react-app/package.json index 344cd4a0214..6e15a7b472f 100644 --- a/packages/eslint-config-react-app/package.json +++ b/packages/eslint-config-react-app/package.json @@ -12,7 +12,7 @@ ], "peerDependencies": { "babel-eslint": "^7.0.0", - "eslint": "^3.8.1", + "eslint": "^3.16.1", "eslint-plugin-flowtype": "^2.21.0", "eslint-plugin-import": "^2.0.1", "eslint-plugin-jsx-a11y": "^2.2.3", From 6c5a1c8ab75e98df66f04b3cf35d2d0120325ec8 Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 17:07:45 -0800 Subject: [PATCH 5/8] missing `^` --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 137956e06c1..d3fd1c3cb27 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -37,7 +37,7 @@ "css-loader": "0.26.1", "detect-port": "1.0.1", "dotenv": "2.0.0", - "eslint": "3.16.1", + "eslint": "^3.16.1", "eslint-config-react-app": "^0.5.2", "eslint-loader": "1.6.3", "eslint-plugin-flowtype": "2.21.0", From 3270b5dcd8e4f09aacc3b6716757153df6df1ff5 Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 17:08:03 -0800 Subject: [PATCH 6/8] missing ^ --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 97f2ec07a02..1d901323322 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ }, "devDependencies": { "babel-eslint": "7.1.0", - "eslint": "3.16.1", + "eslint": "^3.16.1", "eslint-config-react-app": "0.5.1", "eslint-plugin-flowtype": "2.21.0", "eslint-plugin-import": "2.0.1", From a639490c34b6726c4a7ac5a42d8e0eeed6432dc3 Mon Sep 17 00:00:00 2001 From: Chris Drackett Date: Thu, 2 Mar 2017 22:48:19 -0800 Subject: [PATCH 7/8] pinning main eslint and updating readme --- package.json | 2 +- packages/eslint-config-react-app/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 1d901323322..97f2ec07a02 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ }, "devDependencies": { "babel-eslint": "7.1.0", - "eslint": "^3.16.1", + "eslint": "3.16.1", "eslint-config-react-app": "0.5.1", "eslint-plugin-flowtype": "2.21.0", "eslint-plugin-import": "2.0.1", diff --git a/packages/eslint-config-react-app/README.md b/packages/eslint-config-react-app/README.md index 4d967afb806..45cdfe99be2 100644 --- a/packages/eslint-config-react-app/README.md +++ b/packages/eslint-config-react-app/README.md @@ -17,7 +17,7 @@ If you want to use this ESLint configuration in a project not built with Create First, install this package, ESLint and the necessary plugins. ```sh - npm install --save-dev eslint-config-react-app babel-eslint@7.0.0 eslint@3.8.1 eslint-plugin-flowtype@2.21.0 eslint-plugin-import@2.0.1 eslint-plugin-jsx-a11y@2.2.3 eslint-plugin-react@6.4.1 + npm install --save-dev eslint-config-react-app babel-eslint@7.0.0 eslint@3.16.1 eslint-plugin-flowtype@2.21.0 eslint-plugin-import@2.0.1 eslint-plugin-jsx-a11y@2.2.3 eslint-plugin-react@6.4.1 ``` Then create a file named `.eslintrc` with following contents in the root folder of your project: From 4e9f4e32e7fa437d5a1ed320d32c0b4b54fcc0d1 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 5 Mar 2017 14:53:23 +0000 Subject: [PATCH 8/8] Pin ESLint version --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index d3fd1c3cb27..137956e06c1 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -37,7 +37,7 @@ "css-loader": "0.26.1", "detect-port": "1.0.1", "dotenv": "2.0.0", - "eslint": "^3.16.1", + "eslint": "3.16.1", "eslint-config-react-app": "^0.5.2", "eslint-loader": "1.6.3", "eslint-plugin-flowtype": "2.21.0",