From 1eb3d91ee39546f8e8acf9fbbf9eb5f08b8cf035 Mon Sep 17 00:00:00 2001 From: Marius Wirtherle Date: Thu, 1 Jun 2017 13:15:55 +0200 Subject: [PATCH 1/3] docs: added REACT_EDITOR to `Advanced Configuration` section --- packages/react-dev-utils/launchEditor.js | 3 ++- packages/react-scripts/template/README.md | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/react-dev-utils/launchEditor.js b/packages/react-dev-utils/launchEditor.js index a1893d13bc8..44277789ccc 100644 --- a/packages/react-dev-utils/launchEditor.js +++ b/packages/react-dev-utils/launchEditor.js @@ -139,7 +139,8 @@ function printInstructions(fileName, errorMessage) { ' to the ' + chalk.green('.env.local') + ' file in your project folder ' + - 'and restart the development server.' + 'and restart the development server. More info: ' + + chalk.green('https://goo.gl/MMTaZt') ); console.log(); } diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 080329cffad..069ae74b872 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -1820,6 +1820,7 @@ PORT | :white_check_mark: | :x: | By default, the development web server will at HTTPS | :white_check_mark: | :x: | When set to `true`, Create React App will run the development server in `https` mode. PUBLIC_URL | :x: | :white_check_mark: | Create React App assumes your application is hosted at the serving web server's root or a subpath as specified in [`package.json` (`homepage`)](#building-for-relative-paths). Normally, Create React App ignores the hostname. You may use this variable to force assets to be referenced verbatim to the url you provide (hostname included). This may be particularly useful when using a CDN to host your application. CI | :large_orange_diamond: | :white_check_mark: | When set to `true`, Create React App treats warnings as failures in the build. It also makes the test runner non-watching. Most CIs set this flag by default. +REACT_EDITOR | :white_check_mark: | :x: | When this environment variable is set to a shell command that opens your editor, clicking on the error overlay will open the file in your editor. Make sure your systems [PATH](https://en.wikipedia.org/wiki/PATH_(variable)) environment variable points to your editors bin Folder. On macOS Create React App will automatically detect the editor you are using. ## Troubleshooting From 27688ec3a79114c8614135fcd824e2b0c9c6f03c Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 27 Jun 2017 16:28:26 +0100 Subject: [PATCH 2/3] Update README.md --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 069ae74b872..f0b55a85295 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -1820,7 +1820,7 @@ PORT | :white_check_mark: | :x: | By default, the development web server will at HTTPS | :white_check_mark: | :x: | When set to `true`, Create React App will run the development server in `https` mode. PUBLIC_URL | :x: | :white_check_mark: | Create React App assumes your application is hosted at the serving web server's root or a subpath as specified in [`package.json` (`homepage`)](#building-for-relative-paths). Normally, Create React App ignores the hostname. You may use this variable to force assets to be referenced verbatim to the url you provide (hostname included). This may be particularly useful when using a CDN to host your application. CI | :large_orange_diamond: | :white_check_mark: | When set to `true`, Create React App treats warnings as failures in the build. It also makes the test runner non-watching. Most CIs set this flag by default. -REACT_EDITOR | :white_check_mark: | :x: | When this environment variable is set to a shell command that opens your editor, clicking on the error overlay will open the file in your editor. Make sure your systems [PATH](https://en.wikipedia.org/wiki/PATH_(variable)) environment variable points to your editors bin Folder. On macOS Create React App will automatically detect the editor you are using. +REACT_EDITOR | :white_check_mark: | :x: | When an app crashes in development, you will see an error overlay with clickable stack trace. When you click on it, Create React App will try to determine the editor you are using based on currently running processes, and open the relevant source file. You can [send a pull request to detect your editor of choice](https://github.com/facebookincubator/create-react-app/issues/2636). Setting this environment variable overrides the automatic detection. If you do it, make sure your systems [PATH](https://en.wikipedia.org/wiki/PATH_(variable)) environment variable points to your editor’s bin folder. ## Troubleshooting From 6555baad683049d4303b998b5916f3408dcca70f Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 27 Jun 2017 16:30:06 +0100 Subject: [PATCH 3/3] Update launchEditor.js --- packages/react-dev-utils/launchEditor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/launchEditor.js b/packages/react-dev-utils/launchEditor.js index 44277789ccc..fab47d1c335 100644 --- a/packages/react-dev-utils/launchEditor.js +++ b/packages/react-dev-utils/launchEditor.js @@ -139,7 +139,7 @@ function printInstructions(fileName, errorMessage) { ' to the ' + chalk.green('.env.local') + ' file in your project folder ' + - 'and restart the development server. More info: ' + + 'and restart the development server. Learn more: ' + chalk.green('https://goo.gl/MMTaZt') ); console.log();