From 462e5d35ba326294ba14d861e00ba7a8f4608b8c Mon Sep 17 00:00:00 2001 From: varnav Date: Thu, 8 Jun 2017 12:32:01 +0300 Subject: [PATCH 1/2] Fix incorrect check if CI variable is set to true Originally build would fail on warnings with any value of CI environment variable. Now it will correctly check if it's true. Discussed here: https://github.com/facebookincubator/create-react-app/issues/2453 --- packages/react-scripts/scripts/build.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index a83d287ded4..69ecbee2dfa 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -112,7 +112,7 @@ function build(previousFileSizes) { if (messages.errors.length) { return reject(new Error(messages.errors.join('\n\n'))); } - if (process.env.CI && messages.warnings.length) { + if (process.env.CI && process.env.CI.toLowerCase() === 'true' && messages.warnings.length) { console.log( chalk.yellow( '\nTreating warnings as errors because process.env.CI = true.\n' + From 3f5a625c623dea7bc620aa8f264d880bbc86446a Mon Sep 17 00:00:00 2001 From: varnav Date: Thu, 8 Jun 2017 19:00:25 +0300 Subject: [PATCH 2/2] Check for "not false" instead of "not true" After discussion we decided that this will be closer to current functionality and not break anything. --- packages/react-scripts/scripts/build.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index 69ecbee2dfa..aa95774f551 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -112,7 +112,7 @@ function build(previousFileSizes) { if (messages.errors.length) { return reject(new Error(messages.errors.join('\n\n'))); } - if (process.env.CI && process.env.CI.toLowerCase() === 'true' && messages.warnings.length) { + if (process.env.CI && process.env.CI.toLowerCase() !== 'false' && messages.warnings.length) { console.log( chalk.yellow( '\nTreating warnings as errors because process.env.CI = true.\n' +