From db84d25c290afb9712951af9f9fd618cf3f86832 Mon Sep 17 00:00:00 2001 From: Enoah Netzach Date: Wed, 28 Jun 2017 16:30:45 +0200 Subject: [PATCH 1/2] Fix a command style in docs --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1c93e310da3..68a9c4e09cc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -92,7 +92,7 @@ and then run `npm start` or `npm run build`. ## Contributing to E2E (end to end) tests -**TL;DR** use the command yarn e2e:docker to run unit and e2e tests. +**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests. More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md). From 9147cd6b824909c77e447f391440cd50b76700af Mon Sep 17 00:00:00 2001 From: Enoah Netzach Date: Wed, 28 Jun 2017 16:31:00 +0200 Subject: [PATCH 2/2] Add a link to docker's docs --- packages/react-scripts/fixtures/kitchensink/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-scripts/fixtures/kitchensink/README.md b/packages/react-scripts/fixtures/kitchensink/README.md index 8d259d56e94..4e7725ce15f 100644 --- a/packages/react-scripts/fixtures/kitchensink/README.md +++ b/packages/react-scripts/fixtures/kitchensink/README.md @@ -10,6 +10,8 @@ In order to run them locally, without having to manually install and configure e This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen. Simply run `yarn e2e:docker -- --help` to get additional info. +If you need guidance installing **Docker**, you should follow their [official docs](https://docs.docker.com/engine/installation/). + ## Writing tests Each time a new feature is added, it is advised to add at least one test covering it.