From 849a95ca78944264c200db13fa1ff08f715465f4 Mon Sep 17 00:00:00 2001 From: "Leger, David" Date: Mon, 21 Aug 2017 16:43:33 -0300 Subject: [PATCH 1/3] Resolved issue #2971 - changed h2 to h1 in template to adhere to accessibility guidelines. - Added h1 styles to maintain same font size. --- packages/react-scripts/template/src/App.css | 4 ++++ packages/react-scripts/template/src/App.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/template/src/App.css b/packages/react-scripts/template/src/App.css index 15adfdc710c..54e6da56191 100644 --- a/packages/react-scripts/template/src/App.css +++ b/packages/react-scripts/template/src/App.css @@ -14,6 +14,10 @@ color: white; } +.App-header h1 { + font-size: 1.5em; +} + .App-intro { font-size: large; } diff --git a/packages/react-scripts/template/src/App.js b/packages/react-scripts/template/src/App.js index d7d52a7f38a..c3c6ae42f4e 100644 --- a/packages/react-scripts/template/src/App.js +++ b/packages/react-scripts/template/src/App.js @@ -8,7 +8,7 @@ class App extends Component {
logo -

Welcome to React

+

Welcome to React

To get started, edit src/App.js and save to reload. From 00811350189b9fe032be9a9fe95876a1b6493d1d Mon Sep 17 00:00:00 2001 From: "Leger, David" Date: Mon, 21 Aug 2017 20:08:08 -0300 Subject: [PATCH 2/3] Added header tag to template Corrected templete to use semantically correct header tag for header instead of div --- packages/react-scripts/template/src/App.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/template/src/App.js b/packages/react-scripts/template/src/App.js index c3c6ae42f4e..7f2f8c97a57 100644 --- a/packages/react-scripts/template/src/App.js +++ b/packages/react-scripts/template/src/App.js @@ -6,10 +6,10 @@ class App extends Component { render() { return (

-
+
logo

Welcome to React

-
+

To get started, edit src/App.js and save to reload.

From 2603e02c48c1bc5c12dffb59f422a72eb46efe2c Mon Sep 17 00:00:00 2001 From: "Leger, David" Date: Mon, 28 Aug 2017 16:45:07 -0300 Subject: [PATCH 3/3] Added className for App-title - Added className="App-title" to h1 tag - Changed CSS selector to target class instead of element --- packages/react-scripts/template/src/App.css | 2 +- packages/react-scripts/template/src/App.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/template/src/App.css b/packages/react-scripts/template/src/App.css index 54e6da56191..c5c6e8a68ad 100644 --- a/packages/react-scripts/template/src/App.css +++ b/packages/react-scripts/template/src/App.css @@ -14,7 +14,7 @@ color: white; } -.App-header h1 { +.App-title { font-size: 1.5em; } diff --git a/packages/react-scripts/template/src/App.js b/packages/react-scripts/template/src/App.js index 7f2f8c97a57..203067e4d75 100644 --- a/packages/react-scripts/template/src/App.js +++ b/packages/react-scripts/template/src/App.js @@ -8,7 +8,7 @@ class App extends Component {
logo -

Welcome to React

+

Welcome to React

To get started, edit src/App.js and save to reload.