-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update jest to 22 and support watchPathIgnorePatterns configuration #3124
Conversation
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 9b78efc3d74b86b1a5d9eb5a68daec1bf9304331) has been released on npm for testing purposes. npm i react-scripts-dangerous@1.0.14-9b78efc.0
# or
yarn add react-scripts-dangerous@1.0.14-9b78efc.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.14-9b78efc.0 folder/ Thanks for your contribution! |
I've always wanted to build one like it! So good it's actually working :) |
woah, shit. This is cool. |
Amazing 😮 |
So 21.1.0 was released. Might as well update to that? Related issue: #2639. |
You mean upgrade to |
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 95040cb37b04b28e1ea4cb73542381f162f0b09c) has been released on npm for testing purposes. npm i react-scripts-dangerous@1.0.14-95040cb.0
# or
yarn add react-scripts-dangerous@1.0.14-95040cb.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.14-95040cb.0 folder/ Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk! Thanks for your contribution! |
Anybody review this PR? |
@aisensiy bumping major versions of Jest can only be done in a major release of |
@Timer Got it. Thanks for your reply. |
It doesn't seem like major versions of Jest introduced any breaking change so far, why are you still holding on this? |
@FezVrasta looks like v22 adds a lot of breaking changes: CHANGELOG.md |
Anything I can help? |
Any news here? We're getting quite a lot issues in the Jest repo with people trying to upgrade jest themselves and getting relatively obscure errors (it probably silently "worked" with 21 to upgrade, which is why 22 is generating issues as it explodes). Happy to help if needed 🙂 (This PR should probably jump straight to 22 and skip 21) |
If you can get it to 22 and pass CI that would be great! It would also be nice to know why updating |
This looks scary though jestjs/jest#5169 |
I'll give it a whack tomorrow.
Shooting in the dark, but my guess is either a hoisting bug in yarn/npm or some weird (potentially circular) dependency tree we've gotten ourselves into.
Will be solved by jestjs/jest#5252 (so we might want to push out a release of at least that module first) |
…acebook#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.
@Timer You probably want 22.0.6 (released 15 minutes ago), as a memory leak was just fixed (jestjs/jest#5279). (Also, 🎉) |
…acebook#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.
…acebook#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.
…acebook#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.
I can see that this was merged to the (As a sidenote, I noted that the react-dev-tools version in package.json should be updated, because what is on |
…acebook#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.
It shipped in 2.0. |
The jest just add a new configuration property
watchPathIgnorePatterns
in version21.0.0+
which will ignore some path patterns in watch mode.This configuration property make jest support tests which will generate a new file after running the test. Without this watch ignore property, any test which will generate a new file during test in watch mode will make a infinite loop for test. For example if I use pact-js in my create-react-app project. The pact-js test will generate a new
pact file
after running the pact contract test. I create a repository pact-integration-with-react-app to demonstrate this case. Run all the test in watch mode will show the infinite loop.This is the document for the new
watchPathIgnorePatterns
in jest.