-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add experimental babel-plugin-macros support #3675
Conversation
closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well.
Copied from the linked issue: Ok, so, check this out:
(this would be implemented as part of
So that's pretty rock solid awesome... 😄 Note: that was before the |
I understand that it is a massive change but any chance this could land "unsupported" without having to wait for 2.0? Landing it would allow a lot of people to test this actually out in the wild and promote adding macros support to various babel plugins. |
Merged into |
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
* add experimental babel-plugin-macros support closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well. * Pin the version
Support for this has been released in the first v2 alpha version. See #3815 for more details! |
* add experimental babel-plugin-macros support closes facebook#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](facebook#2730 (comment)) and it worked well. * Pin the version
It shipped in 2.0. |
This is just awesome! 🎉 |
Do you have to eject to make it work? |
You're probably trying to use an outdated macro. What are you trying to use? |
I'm trying to use https://github.com/leoasis/graphql-tag.macro |
Yeah, that needs to be updated to Luckily the upgrade is pretty simple. Pretty much find/replace |
ok thanks! |
closes #2730
This will remain undocumented until the brave have tried it in the wild.
Test Plan:
There's currently no established way to test changes to
babel-preset-react-app
. But I did createunmaintained-react-scripts-babel-macros
a while back and it worked well.