Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile code in parallel #3778

Merged
merged 2 commits into from
Jan 13, 2018
Merged

Compile code in parallel #3778

merged 2 commits into from
Jan 13, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jan 13, 2018 •
edited

Eases #3776

@Timer Timer added this to the 2.0.0 milestone Jan 13, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 13, 2018

How stable is it?

@Timer Timer added this to Meh in 2.0 Jan 13, 2018
gaearon
gaearon approved these changes Jan 13, 2018
View reviewed changes
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but:

  • shouldn't we also enable it in prod?
  • let's add a one-line comment before it

@Timer
Copy link
Contributor Author

Timer commented Jan 13, 2018

Whoops, I meant to do both.

@gaearon gaearon merged commit 844e9dc into facebook:next Jan 13, 2018
2.0 automation moved this from Meh to Ready Jan 13, 2018
@Timer Timer deleted the cheap-perf branch January 14, 2018 03:18
Timer added a commit that referenced this pull request Jan 14, 2018
@Timer
Compile code in parallel (#3778)
7079451 
* Cheap perf gains

* Whoopsie
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer @gaearon
Compile code in parallel (#3778)
c6aef1d 
* Cheap perf gains

* Whoopsie
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer @gaearon
Compile code in parallel (#3778)
dc61df6 
* Cheap perf gains

* Whoopsie
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer @gaearon
Compile code in parallel (#3778)
a9dc5bf 
* Cheap perf gains

* Whoopsie
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer @gaearon
Compile code in parallel (#3778)
e0f190e 
* Cheap perf gains

* Whoopsie
Timer added a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
@Timer
Compile code in parallel (facebook#3778)
2ed4a70 
* Cheap perf gains

* Whoopsie
@gaearon gaearon mentioned this pull request Jan 16, 2018
Closed
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@Timer @akstuhl
Compile code in parallel (facebook#3778)
f8fd084 
* Cheap perf gains

* Whoopsie
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Compile code in parallel (facebook#3778)
4e2a808 
* Cheap perf gains

* Whoopsie
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
No open projects
2.0
  
Ready
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @gaearon @facebook-github-bot