Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature #3116 extended Jest config #3802

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

garmeeh
Copy link
Contributor

@garmeeh garmeeh commented Jan 15, 2018

To verify this change:

  1. I ran an e2e test using local copy of create react app and verified the test case breaks by adding resetMocks & resetModules to package.json
  2. Made my changes, then I created a new app using the update version of create react app and re-run the test case by adding resetMocks & resetModules to package.json to verify they are now accepted.
  3. Added a an unsupported option such as setupFiles and verified user still gets error message.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon changed the base branch from master to next January 15, 2018 17:01
@gaearon gaearon modified the milestones: 2.x, 2.0.0 Jan 15, 2018
@gaearon gaearon merged commit f5708c6 into facebook:next Jan 15, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

Thanks! Merged into next.

akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants