-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of http-proxy-middleware #5226
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! |
It turns out this was done intentionally so we will be reverting this change. Sorry for the confusion. |
thanks. I've just tried following codes and somehow I got this. 🤔 var express = require('express'); // version is 4.16.3
var proxy = require('http-proxy-middleware'); // version is 0.19.0
var app = express();
app.use('/foo1', proxy({target: 'http://www.example.org', changeOrigin: true})); // works
app.use(proxy('/foo2', {target: 'http://www.example.org', changeOrigin: true})); // got 404
app.use('/foo3/*', proxy({target: 'http://www.example.org', changeOrigin: true})); // works
app.use(proxy('/foo4/*', {target: 'http://www.example.org', changeOrigin: true})); // got 404
app.listen(3000); |
Funny, I just tried that identical code and it worked. Please note that |
refs: https://github.com/chimurai/http-proxy-middleware#tldr