Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of http-proxy-middleware #5226

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

banyan
Copy link
Contributor

@banyan banyan commented Oct 2, 2018

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu added this to the 2.0.4 milestone Oct 2, 2018
@iansu iansu merged commit ab272d2 into facebook:master Oct 2, 2018
@iansu
Copy link
Contributor

iansu commented Oct 2, 2018

Thanks!

@iansu
Copy link
Contributor

iansu commented Oct 2, 2018

It turns out this was done intentionally so we will be reverting this change. Sorry for the confusion.

@iansu iansu removed this from the 2.0.4 milestone Oct 2, 2018
@banyan
Copy link
Contributor Author

banyan commented Oct 3, 2018

@iansu

thanks. I've just tried following codes and somehow I got this. 🤔

var express = require('express'); // version is 4.16.3
var proxy = require('http-proxy-middleware'); // version is 0.19.0

var app = express();

app.use('/foo1', proxy({target: 'http://www.example.org', changeOrigin: true})); // works
app.use(proxy('/foo2', {target: 'http://www.example.org', changeOrigin: true})); // got 404
app.use('/foo3/*', proxy({target: 'http://www.example.org', changeOrigin: true})); // works
app.use(proxy('/foo4/*', {target: 'http://www.example.org', changeOrigin: true})); // got 404

app.listen(3000);

@Timer
Copy link
Contributor

Timer commented Oct 3, 2018

Funny, I just tried that identical code and it worked. Please note that http://www.example.org responds with 404, not 200. So check the response body.

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants