Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dot from the end of the link to fix it when using from GitHub #5449

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Remove dot from the end of the link to fix it when using from GitHub #5449

merged 1 commit into from
Oct 17, 2018

Conversation

ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Oct 16, 2018

When trying to access the PWD link from GitHub preview the . in the end is included in the link.

image

Clicking on it leads to the following broken path.
This PR fixes it for future readers that will access it from GitHub.

@Timer
Copy link
Contributor

Timer commented Oct 17, 2018

Thanks!

@Timer Timer merged commit 05d3fd2 into facebook:master Oct 17, 2018
@ranyitz ranyitz deleted the fix-cra-pwa-github-broken-link branch October 17, 2018 08:24
thomashorrobin pushed a commit to thomashorrobin/create-react-app-rust that referenced this pull request Oct 17, 2018
@Timer Timer modified the milestones: 2.0.6, 2.1 Oct 22, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants