Avoid pushing .pnp folder to git #5469
Conversation
Avoid pushing .pnp folder to git
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@arcanis ? |
|
as |
|
Yup, sounds good 👍 We'll eventually want to allow them to be checked-in along with the offline cache (install-less Yarn), but at the moment it's better to ignore both of them 🙂 |
|
@gaearon What do you think about it, also I do not have any idea how to rerun |
|
No worries about the CI error, @NShahri. Thanks for this! |
* Add .pnp folder ro gitignore file Avoid pushing .pnp folder to git * Add .pnp.js to ignore list
* Add .pnp folder ro gitignore file Avoid pushing .pnp folder to git * Add .pnp.js to ignore list
* Add .pnp folder ro gitignore file Avoid pushing .pnp folder to git * Add .pnp.js to ignore list
The same as node_modules, .pnp folder should be ignored by git
NOTE:
Not sure about .pnp.js