Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tsconfig.json lib suggested value #5701

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Fix tsconfig.json lib suggested value #5701

merged 1 commit into from
Nov 3, 2018

Conversation

ianschmitz
Copy link
Contributor

Fixes the suggested value for lib, as it was not being populated into the tsconfig.json.

@ianschmitz ianschmitz requested a review from Timer November 3, 2018 19:03
@Timer Timer added this to the 2.1.2 milestone Nov 3, 2018
@Timer Timer merged commit 5cdf360 into facebook:master Nov 3, 2018
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Nov 4, 2018
@ianschmitz @Timer
Fix tsconfig.json lib suggested value (facebook#5701)
f3095fb
@ianschmitz ianschmitz deleted the fix-tsconfig-lib branch November 5, 2018 02:55
xs9627 pushed a commit to xs9627/create-react-app that referenced this pull request Nov 12, 2018
Merge branch 'facebook-master'
a2f2270 
* facebook-master: (578 commits)
  Add PR welcoming badge  (facebook#5759)
  Suggest Encore when not building a SPA with Symfony (facebook#5730)
  Merge webpack configuration (facebook#5722)
  Tweak bot settings
  Update stale.yml
  Fix typo (facebook#5727)
  Version bump postcss-preset-env to latest (facebook#5721)
  Updated the link to firebase hosting (facebook#5710)
  Fixed link to manifest.json file (facebook#5704)
  Fix broken documentation link (facebook#5670)
  Fix tsconfig.json lib suggested value (facebook#5701)
  Add permissive TS lib defaults (facebook#5694)
  Lock issues more aggressively
  Make stale bot configuration more aggressive
  ignore intellij module files when generating an app (facebook#4605)
  update envinfo to 5.11.1 (facebook#5685)
  Add bot config (facebook#4483)
  Publish
  Update cached lock file
  Add changelog for 2.1.1
  ...
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ianschmitz @Timer @facebook-github-bot