-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example command to create typed project #5766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, and thanks for the PR. Let me know if you have any questions on the feedback.
@@ -7,6 +7,11 @@ title: Adding TypeScript | |||
|
|||
[TypeScript](https://www.typescriptlang.org/) is a typed superset of JavaScript that compiles to plain JavaScript. | |||
|
|||
To create a typed React App project run it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind changing this to "To start a new Create React App project with TypeScript, you can run:"
You could also add the Yarn way of doing this, as below (with # or
), which would be yarn create react-app my-app --typescript
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for feedback. Unfortunately I've deleted the source repo. Could I change that with a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to add commits to the PR here, in GitHub directly @mbelsky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand to do that the source branch should exist, but it isn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I see that issue too. Can you create a new PR? I'll close this one off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New PR: #6015
Closing as source branch was deleted and changes cannot be made. New PR will be opened shortly. |
Hey,
I've found this command in v2.1.0 release notes and I think it's important to have it in docs. However I'm not sure that this file is a correct place to put that example.
What is your opinion on this?