chore: simplify TypeScript configs, use TS 5.5 configDir placeholder (#…

…10256)
facebook · Jul 11, 2024 · ee115ed · ee115ed
1 parent 8e51453
commit ee115ed
Show file tree

Hide file tree

Showing 54 changed files with 45 additions and 247 deletions.
diff --git a/.github/workflows/tests-windows.yml b/.github/workflows/tests-windows.yml
@@ -58,9 +58,9 @@ jobs:
         run: yarn workspace website typecheck
       - name: TypeCheck website - min version - v5.1
         run: |
-          yarn add typescript@5.1.6 --exact -D -W
+          yarn add typescript@5.1.6 --exact -D -W --ignore-scripts
           yarn workspace website typecheck
       - name: TypeCheck website - max version - Latest
         run: |
-          yarn add typescript@latest --exact -D -W
+          yarn add typescript@latest --exact -D -W --ignore-scripts
           yarn workspace website typecheck
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -49,9 +49,9 @@ jobs:
         run: yarn workspace website typecheck
       - name: TypeCheck website - min version - v5.1
         run: |
-          yarn add typescript@5.1.6 --exact -D -W
+          yarn add typescript@5.1.6 --exact -D -W --ignore-scripts
           yarn workspace website typecheck
       - name: TypeCheck website - max version - Latest
         run: |
-          yarn add typescript@latest --exact -D -W
+          yarn add typescript@latest --exact -D -W --ignore-scripts
           yarn workspace website typecheck
diff --git a/__tests__/validate-tsconfig.test.ts b/__tests__/validate-tsconfig.test.ts
@@ -35,15 +35,6 @@ const tsconfigSchema = Joi.object({
     '../../tsconfig.base.json',
     '../../tsconfig.base.client.json',
   ),
-  compilerOptions: Joi.object({
-    rootDir: Joi.valid('src').required(),
-    outDir: Joi.valid('lib').required(),
-    tsBuildInfoFile: Joi.valid(
-      'lib/.tsbuildinfo',
-      'lib/.tsbuildinfo-client',
-      'lib/.tsbuildinfo-worker',
-    ),
-  }).unknown(),
 }).unknown();
 
 describe('tsconfig files', () => {
@@ -52,7 +43,6 @@ describe('tsconfig files', () => {
 
     tsconfigFiles
       // Ignore noEmit configs
-      .filter((file) => !(file.content.compilerOptions!.noEmit === true))
       .forEach((file) => {
         try {
           Joi.attempt(file.content, tsconfigSchema);

diff --git a/packages/create-docusaurus/tsconfig.build.json b/packages/create-docusaurus/tsconfig.build.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "noEmit": false,
-    "composite": true,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "tsBuildInfoFile": "lib/.tsbuildinfo-build"
   },
   "include": ["src"],
   "exclude": ["templates/", "**/__tests__/**"]

diff --git a/packages/create-docusaurus/tsconfig.json b/packages/create-docusaurus/tsconfig.json
@@ -5,6 +5,6 @@
     "noEmit": true,
     "rootDir": "."
   },
-  "include": ["bin"],
+  "include": ["package.json", "bin"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-cssnano-preset/tsconfig.json b/packages/docusaurus-cssnano-preset/tsconfig.json
@@ -1,11 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-logger/tsconfig.json b/packages/docusaurus-logger/tsconfig.json
@@ -2,12 +2,8 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
     "sourceMap": true,
-    "declarationMap": true,
-    "rootDir": "src",
-    "outDir": "lib"
+    "declarationMap": true
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-mdx-loader/tsconfig.json b/packages/docusaurus-mdx-loader/tsconfig.json
@@ -2,14 +2,9 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
     "sourceMap": true,
-    "declarationMap": true,
-    "rootDir": "src",
-    "outDir": "lib",
-    "types": []
+    "declarationMap": true
   },
-  "include": ["src"],
+  "include": ["package.json", "src"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-client-redirects/tsconfig.json b/packages/docusaurus-plugin-client-redirects/tsconfig.json
@@ -1,11 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-content-blog/tsconfig.client.json b/packages/docusaurus-plugin-content-blog/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/client", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-content-blog/tsconfig.json b/packages/docusaurus-plugin-content-blog/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/client", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-content-docs/tsconfig.client.json b/packages/docusaurus-plugin-content-docs/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/client", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-content-docs/tsconfig.json b/packages/docusaurus-plugin-content-docs/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/client", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-content-pages/tsconfig.json b/packages/docusaurus-plugin-content-pages/tsconfig.json
@@ -1,11 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-debug/tsconfig.client.json b/packages/docusaurus-plugin-debug/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/theme", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-debug/tsconfig.json b/packages/docusaurus-plugin-debug/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/theme", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-google-analytics/tsconfig.client.json b/packages/docusaurus-plugin-google-analytics/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/analytics.ts", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-google-analytics/tsconfig.json b/packages/docusaurus-plugin-google-analytics/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/analytics.ts", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-google-gtag/tsconfig.client.json b/packages/docusaurus-plugin-google-gtag/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/gtag.ts", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-google-gtag/tsconfig.json b/packages/docusaurus-plugin-google-gtag/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/gtag.ts", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-google-tag-manager/tsconfig.client.json b/packages/docusaurus-plugin-google-tag-manager/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-google-tag-manager/tsconfig.json b/packages/docusaurus-plugin-google-tag-manager/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-ideal-image/tsconfig.client.json b/packages/docusaurus-plugin-ideal-image/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/theme", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-ideal-image/tsconfig.json b/packages/docusaurus-plugin-ideal-image/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/theme", "**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-pwa/tsconfig.client.json b/packages/docusaurus-plugin-pwa/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": [
     "src/theme/",
     "src/*.d.ts",

diff --git a/packages/docusaurus-plugin-pwa/tsconfig.json b/packages/docusaurus-plugin-pwa/tsconfig.json
@@ -5,11 +5,7 @@
     {"path": "./tsconfig.worker.json"}
   ],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": [

diff --git a/packages/docusaurus-plugin-pwa/tsconfig.worker.json b/packages/docusaurus-plugin-pwa/tsconfig.worker.json
@@ -2,12 +2,8 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "noEmit": false,
-    "composite": true,
-    "incremental": true,
     "lib": ["webworker", "esnext"],
     "tsBuildInfoFile": "lib/.tsbuildinfo-worker",
-    "rootDir": "src",
-    "outDir": "lib",
     "moduleResolution": "bundler",
     "module": "esnext",
     "target": "esnext",

diff --git a/packages/docusaurus-plugin-sitemap/tsconfig.json b/packages/docusaurus-plugin-sitemap/tsconfig.json
@@ -1,11 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]

diff --git a/packages/docusaurus-plugin-vercel-analytics/tsconfig.client.json b/packages/docusaurus-plugin-vercel-analytics/tsconfig.client.json
@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.client.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "lib",
-    "tsBuildInfoFile": "lib/.tsbuildinfo-client"
-  },
   "include": ["src/analytics.ts", "src/options.ts", "src/*.d.ts"],
   "exclude": ["**/__tests__/**"]
 }
diff --git a/packages/docusaurus-plugin-vercel-analytics/tsconfig.json b/packages/docusaurus-plugin-vercel-analytics/tsconfig.json
@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.base.json",
   "references": [{"path": "./tsconfig.client.json"}],
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["src/analytics.ts", "**/__tests__/**"]

diff --git a/packages/docusaurus-preset-classic/tsconfig.json b/packages/docusaurus-preset-classic/tsconfig.json
@@ -1,11 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "noEmit": false,
-    "incremental": true,
-    "tsBuildInfoFile": "lib/.tsbuildinfo",
-    "rootDir": "src",
-    "outDir": "lib"
+    "noEmit": false
   },
   "include": ["src"],
   "exclude": ["**/__tests__/**"]