Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sidebar_label in pagination buttons. #1085

Closed
maxaggedon opened this issue Nov 2, 2018 · 2 comments
Closed

Use sidebar_label in pagination buttons. #1085

maxaggedon opened this issue Nov 2, 2018 · 2 comments

Comments

@maxaggedon
Copy link
Contributor

🚀 Feature

Display sidebar_label (if existing) of the previous and next docs instead of the title in bottom pagination buttons.

Have you read the Contributing Guidelines on issues?

yes

Motivation

If it has been set, sidebar_label is meant to be used for navigation (it could even be renamed nav_label). And it will certainly be shorter than title which will prevent some ugly UI cases...

Pitch

As a user I thought it would be the case. Why would I set an explicit label for navigation purposes and not see it in pagination?
I would be glad to work on a PR if the idea is accepted =)

@huguestennier
Copy link

Should be fixed in v1.5.1.

See related PR : #1079

@maxaggedon
Copy link
Contributor Author

maxaggedon commented Nov 21, 2018

@huguestennier the PR you mention fixes a bug where the buttons always displays previous and next. With this fix, it displays the articles' title if existing. (Please correct me if I am wrong)

What I suggest is to display sidebar_label instead of title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants