Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect internal broken links during build #3048

Closed
omry opened this issue Jul 11, 2020 · 3 comments · Fixed by #3059
Closed

Detect internal broken links during build #3048

omry opened this issue Jul 11, 2020 · 3 comments · Fixed by #3059
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.

Comments

@omry
Copy link

omry commented Jul 11, 2020

🚀 Feature

A website should fail to build if it has internal broken links.

Have you read the Contributing Guidelines on issues?

Not relevant for feature requests, is it?

Motivation

While building the website, it's all to easy to change the page filename and forget or miss incoming internal links.

Pitch

It will help create higher quality websites and reduce the churn of "easy" incoming pull requests fixing minor issues in the docs.
@omry omry added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Jul 11, 2020
@slorber
Copy link
Collaborator

slorber commented Jul 13, 2020

agree, this is definitively something we need

@slorber slorber added v2 and removed status: needs triage This issue has not been triaged by maintainers labels Jul 13, 2020
@slorber slorber mentioned this issue Jul 14, 2020
Merged
@slorber
Copy link
Collaborator

slorber commented Jul 14, 2020

check #3059

@slorber slorber linked a pull request Jul 14, 2020 that will close this issue
feat(v2): broken links detection #3059
Merged
@omry
Copy link
Author

omry commented Jul 14, 2020

awesome, that was quick!

@adrianmcli adrianmcli mentioned this issue Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v2): broken links detection facebook/docusaurus
2 participants
@omry @slorber