-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: upgrade Remark to v13.0.0 #3668
Comments
Thanks, we'll look into upgrading to Remark 13 but probably a bit later |
Not exactly true, we are using Remark 12 to execute tests. To render MD content, we use |
Great, thanks for the clarification @lex111. |
We spoke a while back about separating markdown from mdx, e.g., |
See also mdx-js/mdx#1367, recently merged, for progress on integrating Remark 13 into MDX ( |
I stated this in the other issues but FWIW xdm is always in sync with the latest remark, and for that matter every other package in the unified ecosystem 🙄 |
@wooorm said recently that he's backporting xdm in mdx so we should be able to keep using mdx too |
Going to close this in favor of #4029. I originally kept this open because I planned to parse Markdown on the server with Remark (see #6261), but due to performance and ROI reasons, I eventually decided that regex is still the best solution. Therefore, the only blocking issue is migration to MDX v2. |
💥 Proposal: upgrade Remark to v13.0.0
It looks like the mdx-loader is using Remark v12.0.0: https://github.com/facebook/docusaurus/blob/master/packages/docusaurus-mdx-loader/package.json#L39
Remark v13.0.0 was released in mid-October. The release notes explain that "It replaces the 5+ year old internals with a new low-level parser:
micromark
.": https://github.com/remarkjs/remark/releases/tag/13.0.0Reasons to upgrade:
Concerns:
remark-admonitions
(used in packages such asdocusaurus-plugin-content-docs
) does not yet work with v13. This may mean that we may need to wait for all of the remark plugins to be updated before we upgrade Remark. We can track whether various Remark plugins are compatible with v13 here: https://github.com/remarkjs/remark/blob/main/doc/plugins.md#list-of-pluginsHave you read the Contributing Guidelines on issues?
Yes
The text was updated successfully, but these errors were encountered: