-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Graph tags missing required property of og:type #5373
Comments
According to this page, og:type is additional type and provides default value ( |
The page linked to is how Facebook use the Open Graph tags; so whilst the lack of Even if we just supply the default value of: <meta property="og:type" content="website" /> it will then be explicitly specified and also opens the possibility for more customisation further down the line. I've been slightly going down the rabbit hole of reading about all this stuff, I'd quite like the ability for us to do more in this space in future perhaps. Not quite sure what that would look like, feels like a combination of |
This is a quote from OG protocol, so if
|
Good find - maybe it's not really a specific issue generally.
Agree this could be a good idea. |
PRs welcome to add that type Was wondering what type is a doc page and shouldn't we add relevant structured data on docs too? |
I've got something locally that's pretty generic - I'll put it up for comments. Should serve a number of purposes I think |
See related PR: #5375 |
* feat: add metatags support for seo / blogposts * feat: different implementation * feat: use isBlogPostPage * feat: implement in BlogPostPage-remove Seo changes * Revert "feat: implement in BlogPostPage-remove Seo changes" This reverts commit 1cba459 * Move Seo to BlogPostPage + some fixes * fix social preview asset * Fix blog social image + improve a bit Seo setup * fix bootstrap theme Co-authored-by: John <john.reilly@investec.co.uk> Co-authored-by: slorber <lorber.sebastien@gmail.com>
@johnnyreilly May I know what the state of this issue is? Is |
I've actually forgotten where this ended up. I don't think any changes have been made - I haven't checked recently and I'm away from a machine right now |
will it ever get fixed or merged ? |
Based on the discussion above, we are still unsure whether it's required or even needed. If you want to send a PR to add it, I'm okay to merge it, but this is not prioritized. I haven't even triaged this issue for that purpose. @johnnyreilly Any thoughts? |
Sorry I think this was resolved with my PR - will close |
🐛 Bug Report
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
Open Graph tags are amazing and I've been reading up on them. There's four that are required:
Docusaurus does not provide
og:type
at present. It would be good if it did; perhaps with a value ofwebsite
orarticle
. eg:Have you read the Contributing Guidelines on issues?
Yes
Steps to reproduce
Look at the og tags on the docusaurus website: https://docusaurus.io/blog
Expected behavior
To have an
og:type
tagActual behavior
Does not have
og:type
tagYour environment
All environments
Reproducible demo
Look at the og tags on the docusaurus website: https://docusaurus.io/blog
Given the work in #5355 @lex111 - I wondered if you might have thoughts on this too.
The text was updated successfully, but these errors were encountered: