Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project name in header bar on mobile #613

Closed
JoelMarcey opened this issue Apr 28, 2018 · 4 comments
Closed

Remove project name in header bar on mobile #613

JoelMarcey opened this issue Apr 28, 2018 · 4 comments
Labels
difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. status: claimed Issue has been claimed by a contributor who plans to work on it.

Comments

@JoelMarcey
Copy link
Contributor

JoelMarcey commented Apr 28, 2018 •
edited
Loading

Is this a bug report?

No. Better user experience. See #575 for discussion.

Have you read the Contributing Guidelines on issues?

Yes

Environment

N/A

Steps to Reproduce

  1. Go to docusaurus.io on mobile

Expected Behavior

Cleaner header nav with the search bar without project name

Actual Behavior

Project name exists

(Write what happened. Add screenshots, if applicable.)

Reproducible Demo

N/A
@JoelMarcey JoelMarcey added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. labels Apr 28, 2018
@yangshun
Copy link
Contributor

This might be a problem for projects without a logo, like https://twitchtv.github.io/twirp/docs/intro.html

@JoelMarcey
Copy link
Contributor Author

@yangshun That is a fair point actually. In that case, we could just stick with the title or nothing maybe?

@yangshun
Copy link
Contributor

Sounds like a good idea. Hide the title if there's a logo, else do nothing 👍

@yangshun yangshun added the status: claimed Issue has been claimed by a contributor who plans to work on it. label May 3, 2018
@yangshun
Copy link
Contributor

yangshun commented May 3, 2018

Claimed by @amyrlam

@amyrlam amyrlam mentioned this issue May 3, 2018
Merged
@NikolayS NikolayS mentioned this issue Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. status: claimed Issue has been claimed by a contributor who plans to work on it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangshun @JoelMarcey