Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load external images #6965

Closed
6 of 7 tasks
rilwis opened this issue Mar 23, 2022 · 1 comment · Fixed by #6990
Closed
6 of 7 tasks

Lazy load external images #6965

rilwis opened this issue Mar 23, 2022 · 1 comment · Fixed by #6990
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.

Comments

@rilwis
Copy link

rilwis commented Mar 23, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

I see lazy load was merged into version beta 16. However, I'm using version beta 17 and see it doesn't work for external images from imgur.com.

Reproducible demo

https://meta-box-docs-v2.netlify.app/custom-fields/

Steps to reproduce

Just visit a page with many images, the images below the fold are loaded immediately.

Expected behavior

The images below the fold should be lazy loaded.

Actual behavior

The images below the fold are loaded immediately.

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@rilwis rilwis added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Mar 23, 2022
@Josh-Cena Josh-Cena added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. and removed status: needs triage This issue has not been triaged by maintainers bug An error in the Docusaurus core causing instability or issues with its execution labels Mar 23, 2022
@Josh-Cena Josh-Cena changed the title Lazy load not working for external images Lazy load external images Mar 23, 2022
@Josh-Cena
Copy link
Collaborator

I wouldn't call this a regression, because never have we transformed Markdown images that don't appear internal. I do believe this looks like a useful extension to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants