Auto-generated title incorrect when not using Unix newline encoding (LF)

[andgeno]

Have you read the Contributing Guidelines on issues?

• I have read the Contributing Guidelines on issues.

Prerequisites

• I'm using the latest version of Docusaurus.
• I have tried the npm run clear or yarn clear command.
• I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
• I have tried creating a repro with https://new.docusaurus.io.
• I have read the console error message carefully (if applicable).

Description

Page titles will be rendered incorrectly depending on which newline format has been chosen.

✔ Linux (LF): Works as expected. Text of the first Markdown header is displayed.
❌ Windows (CRLF): Original filename and text of the first Markdown header is displayed.
❌ macOS (CR): Original filename is displayed. It's also missing the "Hello" text.

Here is a repro repository:

https://github.com/andgeno/docusaurus-repro-newline-encoding-bug

See the second commit for the actual demo files involved.

Some screenshots:

Reproducible demo

https://github.com/andgeno/docusaurus-repro-newline-encoding-bug

Steps to reproduce

• Create a new file and encode it Windows or macOS newline format.
• Add a Markdown header to make the title look different / nicer than just the raw filename.
• Visit page of that new file.
• Page title will be rendered incorrectly.

Expected behavior

Titles should render the same in all cases.

Actual behavior

Titles render wrong depending on chosen newline format.

Your environment

• Docusaurus version used: 2.0.0-beta.18

Self-service

• I'd be willing to fix this bug myself.

[Josh-Cena]

Duplicate of #7044

[Josh-Cena]

Also, I've never seen a text editor, macOS (unless you use a super old one) or anywhere else, that uses only CR for line breaks. TBF, you should always normalize line endings to LF.

[andgeno]

The thing is that I've been banging my head for over an hour on this issue until I noticed something is wrong with the newline formatting. I'm using IntelliJ and it creates CRLF-encoded files while the example files created using Docusaurus are LF-encoded. The IDE is behaving correctly since I'm working on a Windows machine. So either Docusaurus should apply normalization on example files or handle other NL formats correctly.

EDIT:
Maybe I should clarify that I only seek proper support for LF/CRLF. CR is indeed an archaic newline format and probably not to be found anywhere anymore. I simply did a complete test on all possibilities once I noticed this issue and this included CR. ;-)

[Josh-Cena]

Yeah, it's an inconsiderate bug and already fixed in #7043. The reason why it's not caught is because our repo performs LF normalization and there's no test run on CRLF. But honestly, I feel like the very existence of CRLF is a bug in itself ;) Just saying