-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-https URLs http://schema.org/Blog and BlogPosting in classic theme #9181
Comments
Thanks, that seems reasonable to use https links consistently (some of them already are https btw) Does anyone want to submit a PR? |
does the build-snap file gets created automatically when we build the test folder? @slorber |
We had just been wondering about it in #9151 😄 Looks like the answer is no, so you would have to run a build yourself and copy the HTML output. |
I think the HTML build gets created by running jest packages/docusaurus-plugin-content-blog/src/tests/index.test.ts but I have been unsuccessful in doing that. |
No, unfortunately— |
I see! |
Thanks for the quick fix folks! |
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
My broken link checker is complaining about http links in the generated page. Looks like these are:
docusaurus/packages/docusaurus-theme-classic/src/theme/BlogPostItem/Container/index.tsx
Line 30 in 983fb2d
docusaurus/packages/docusaurus-theme-classic/src/theme/BlogLayout/index.tsx
Line 30 in 983fb2d
docusaurus/packages/docusaurus-plugin-content-blog/src/__tests__/__fixtures__/website/build-snap/blog/index.html
Line 14 in 983fb2d
And were introduced in #5355
Reproducible demo
No response
Steps to reproduce
I believe this should reproduce with any site using the Blog theme.
Expected behavior
HTTPS links instead
Actual behavior
HTTP links
Your environment
main
Self-service
The text was updated successfully, but these errors were encountered: