-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ToC generation when importing markdown (Docusaurus v2) #9682
fix: ToC generation when importing markdown (Docusaurus v2) #9682
Conversation
Hi @anatolykopyl! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
I consider this PR done. |
thanks for your work @anatolykopyl However we don't merge new features and bugfixes to the v2 branch anymore, and will only handle critical security v2 issues until the end of January. https://docusaurus.io/community/release-process#stable-version I'll look at your v3 PR when I have time |
Pre-flight checklist
Motivation
This PR adapts the fix to ToC generation from shuding/nextra#2199 to the toc remark plugin in docusaurus-v2.
Test Plan
Now the title from
_pagePartial.md
is visible in the ToC of the/tests/pages
page.Also I've added a
/tests/pages/partials-tests
page for further demonstration.Test links
Deploy preview: https://deploy-preview-9682--docusaurus-2.netlify.app/
Affected test page: https://deploy-preview-9682--docusaurus-2.netlify.app/tests/pages
New test page: https://deploy-preview-9682--docusaurus-2.netlify.app/tests/pages/partials-tests
Related issues/PRs
#3915