This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add default value for blockRenderMap #1302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadsm
reviewed
Aug 24, 2017
flarnie
suggested changes
Sep 6, 2017
|
Would still like to get this fix in - I'll add a quick test based on the example from the issue. |
**what is the change?:** Adding a test for the solution to issue facebookarchive#1211 In general I prefer testing the public API, so we actually render an example editor and trigger the situation which used to throw an error. **why make this change?:** We need better unit tests for Draft, and this will help stop the bug from recurring if someone randomly removes that check in the future. **test plan:** `yarn run test src/component/contents/__tests__/DraftEditorContent.react-test.js` We tried temporarily undoing the fix and running the test, and verified that it failed. **issue:** facebookarchive#1211
flarnie
approved these changes
Sep 20, 2017
|
Adding this to the queue for merging~✨ |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: **Summary** PR for issue 1211 facebookarchive/draft-js#1211 **Test Plan** <s>no need</s> **Edit by Flarnie:** added unit test Closes facebookarchive/draft-js#1302 Reviewed By: zpao Differential Revision: D5881334 Pulled By: zpao fbshipit-source-id: b8d57b23a1654fe9cdcf84b74b25617413ef6248
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** PR for issue 1211 facebookarchive/draft-js#1211 **Test Plan** <s>no need</s> **Edit by Flarnie:** added unit test Closes facebookarchive/draft-js#1302 Reviewed By: zpao Differential Revision: D5881334 Pulled By: zpao fbshipit-source-id: b8d57b23a1654fe9cdcf84b74b25617413ef6248
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** PR for issue 1211 facebookarchive/draft-js#1211 **Test Plan** <s>no need</s> **Edit by Flarnie:** added unit test Closes facebookarchive/draft-js#1302 Reviewed By: zpao Differential Revision: D5881334 Pulled By: zpao fbshipit-source-id: b8d57b23a1654fe9cdcf84b74b25617413ef6248
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR for issue 1211
#1211
Test Plan
no needEdit by Flarnie: added unit test