This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix rich text utils backspace not clearing the block type at the start. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
^ Looks like Travis might need a retry? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
flarnie
approved these changes
Oct 14, 2017
| @@ -59,7 +59,7 @@ describe('RichTextEditorUtil', () => { | |||
|
|
|||
| // Remove the current text from the blockquote. | |||
| const resetBlockquote = DraftModifier.removeRange( | |||
| editorState.getCurrentContent(), | |||
| contentState, | |||
There was a problem hiding this comment.
Nice - thanks for fixing that.
| @@ -82,6 +82,27 @@ describe('RichTextEditorUtil', () => { | |||
| expect(lastBlockNow.getText()).toBe(''); | |||
| }); | |||
|
|
|||
| it('resets the current block type at the start of the first block', () => { | |||
There was a problem hiding this comment.
Thanks for writing a test!
|
I'm going to try and resolve the conflicts, ensure CI passes, and merge this. |
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Woot! Awesome to see this get merged. Thank you! @flarnie |
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: **Summary** When backspacing at the start of the first block using rich text utils, the block type should be cleared. Example of me frantically trying to clear the first block type **without** this PR by pressing backspace at the beginning of the document:  Followed by an example of me clearing the first block type **with** this PR:  **Test Plan** - Pull master. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, notice that it doesn't work. - Pull this branch. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, rejoice in joy as the list item disappears. - Celebrate. 🎉 Closes facebookarchive/draft-js#748 Differential Revision: D6065808 fbshipit-source-id: d4b9028e255be1bdf405cf228cfd16c877872c95
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** When backspacing at the start of the first block using rich text utils, the block type should be cleared. Example of me frantically trying to clear the first block type **without** this PR by pressing backspace at the beginning of the document:  Followed by an example of me clearing the first block type **with** this PR:  **Test Plan** - Pull master. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, notice that it doesn't work. - Pull this branch. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, rejoice in joy as the list item disappears. - Celebrate. 🎉 Closes facebookarchive/draft-js#748 Differential Revision: D6065808 fbshipit-source-id: d4b9028e255be1bdf405cf228cfd16c877872c95
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** When backspacing at the start of the first block using rich text utils, the block type should be cleared. Example of me frantically trying to clear the first block type **without** this PR by pressing backspace at the beginning of the document:  Followed by an example of me clearing the first block type **with** this PR:  **Test Plan** - Pull master. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, notice that it doesn't work. - Pull this branch. - Open the rich text example. - Create a list. - Put your cursor at the first offset of the first block, backspace to reset the block type, rejoice in joy as the list item disappears. - Celebrate. 🎉 Closes facebookarchive/draft-js#748 Differential Revision: D6065808 fbshipit-source-id: d4b9028e255be1bdf405cf228cfd16c877872c95
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When backspacing at the start of the first block using rich text utils, the block type should be cleared.
Example of me frantically trying to clear the first block type without this PR by pressing backspace at the beginning of the document:
Followed by an example of me clearing the first block type with this PR:
Test Plan